Skip to content

Fix "Call API pulls inline API"#492

Merged
recp merged 3 commits into
recp:masterfrom
FunkyAss:fix/call_api_pulls_inline
May 31, 2026
Merged

Fix "Call API pulls inline API"#492
recp merged 3 commits into
recp:masterfrom
FunkyAss:fix/call_api_pulls_inline

Conversation

@FunkyAss

Copy link
Copy Markdown
Contributor

Fixes #491

@recp

recp commented Mar 26, 2026

Copy link
Copy Markdown
Owner

Hi @FunkyAss,

thanks for your contributions,

  • use relative includes internally: cglm/ -> ../ to avoid collisions
  • include/cglm/call/io.h must explicitly include <stdio.h>, common.h doesnt include io/FILE ( cglm.h was )
  • we need to clarify the behavior change in docs/README which is inlines must be included separately than call

@FunkyAss

Copy link
Copy Markdown
Contributor Author

Roger that. I'll address the comments in the next (7-14) days

 - use relative includes for cglm/call/ headers
 - explicitly include stdio in cglm/call/io.h
 - update call documentation
@recp recp merged commit 46f46e5 into recp:master May 31, 2026
@recp

recp commented May 31, 2026

Copy link
Copy Markdown
Owner

@FunkyAss the PR is merged, thanks for your contributions 🚀 sorry for the delay, it looks like in progress for a while...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Call API pulls inline API

2 participants